Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Beckhoff ADS protocol dissector #2181

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add Beckhoff ADS protocol dissector #2181

merged 4 commits into from
Nov 30, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

ADS is the protocol used to communicate with Beckhoff PLCs via their TwinCAT software.

@0xA50C1A1 0xA50C1A1 marked this pull request as draft November 29, 2023 03:16
@0xA50C1A1
Copy link
Contributor Author

0xA50C1A1 commented Nov 29, 2023 •
edited
Loading

I'll re-create when I can finally install ubuntu on qemu-system-s390x to debug that dissector.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@0xA50C1A1 0xA50C1A1 marked this pull request as ready for review November 30, 2023 05:00
@0xA50C1A1
Copy link
Contributor Author

Huh, I finally got it fixed.

IvanNardi
IvanNardi approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@IvanNardi IvanNardi merged commit 24df191 into ntop:dev Nov 30, 2023
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-dissector/beckhoff-ads branch November 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xA50C1A1 @IvanNardi